libbeat/beat: introduce Beat.OutputConfigReloader #28048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Introduce Beat.OutputConfigReloader, an optional reload.Reloadable that may be set by a beat.Creator in order to watch output config changes.
axw
force-pushed
the
beat-outputconfigreloader
branch
from
b2e947f to
e67c93b
Compare
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
removed
the
needs_team
marclop
approved these changes
Oct 4, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2021
Introduce Beat.OutputConfigReloader, an optional reload.Reloadable that may be set by a beat.Creator in order to watch output config changes. (cherry picked from commit 67f2e2b)
axw
added a commit
that referenced
this pull request
Oct 4, 2021
Introduce Beat.OutputConfigReloader, an optional reload.Reloadable that may be set by a beat.Creator in order to watch output config changes. (cherry picked from commit 67f2e2b) Co-authored-by: Andrew Wilkins <[email protected]>
Icedroid
pushed a commit
to Icedroid/beats
that referenced
this pull request
Nov 1, 2021
Introduce Beat.OutputConfigReloader, an optional reload.Reloadable that may be set by a beat.Creator in order to watch output config changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduce
Beat.OutputConfigReloader, an optionalreload.Reloadablethat may be set by abeat.Creatorin order to watch output config changes. This will be called in addition to the reloader that libbeat registers internally.Why is it important?
We can hook into the output reloader using this approach to extract the config we require.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Note regarding testing: normally I would write a test for a change like this, but there does not appear to be any framework for writing similar tests. The code is trivial enough that I don't want to get bogged down introducing a framework.